Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Framerate of videorecoding is not intuitive #303

Open
wurzelkuchen opened this issue Nov 7, 2024 · 0 comments · Fixed by #309
Open

Bug: Framerate of videorecoding is not intuitive #303

wurzelkuchen opened this issue Nov 7, 2024 · 0 comments · Fixed by #309
Assignees
@oomelianchuk
Labels
bug codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there
Milestone
v5.1.0

Comments

@wurzelkuchen
Copy link
Contributor

wurzelkuchen commented Nov 7, 2024 •
edited
Loading

Quick Description

When we capture a video or gif, the playtime of the recording does not match the real time.

We currently only have video/gif.oneImagePerMilliseconds as a property to configure the delay between to images. This property changes the duration of the video, which should not be the case. It should only affect the framerate.

Actual Behaviour

If i record a video of a test with a runtime of X seconds the screen recording is much faster than X seconds and highly depends on the oneImagePerMilliseconds property.

Expected Behaviour

If i record a video of a test with a runtime of X seconds the screen recording should have a duration of X seconds. Changes in the oneImagePerMilliseconds property should not change the playback duration.
@wurzelkuchen wurzelkuchen added bug docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made codeImplementationNeeded This issue requires a change in the code of Neodymium labels Nov 7, 2024
@wurzelkuchen wurzelkuchen mentioned this issue Nov 7, 2024
Open
4 tasks
@oomelianchuk oomelianchuk self-assigned this Nov 11, 2024
oomelianchuk added a commit that referenced this issue Nov 13, 2024
@oomelianchuk
[#303] fix framerate of gif and video recording and add tests for it
83aedce
oomelianchuk added a commit that referenced this issue Nov 13, 2024
@oomelianchuk
[#303] improve error message for the case ffmpeg not found
db1a3c9
@oomelianchuk oomelianchuk linked a pull request Nov 13, 2024 that will close this issue
Bug: Framerate of videorecoding is not intuitive #303 #309
Merged
@oomelianchuk oomelianchuk added codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop and removed codeImplementationNeeded This issue requires a change in the code of Neodymium labels Nov 19, 2024
oomelianchuk added a commit that referenced this issue Nov 26, 2024
@oomelianchuk
[#303] fix jaavdoc
41851bc
oomelianchuk added a commit that referenced this issue Nov 26, 2024
@oomelianchuk
[#303] remove if statement to check if neo version log needed
fbbd847
oomelianchuk added a commit that referenced this issue Nov 27, 2024
@oomelianchuk
[#303] recalculate framerate after test
4a2f782
oomelianchuk added a commit that referenced this issue Nov 28, 2024
@oomelianchuk
Merge branch 'develop'
0c09f7c 
into #303-framerate-of-video-recoring-is-not-intuitive
oomelianchuk added a commit that referenced this issue Nov 28, 2024
@oomelianchuk
[#303] fix after merge
caa0730
wurzelkuchen added a commit that referenced this issue Nov 28, 2024
@wurzelkuchen
Merge pull request #309 from Xceptance/#303-framerate-of-video-recori…
e46dd72 
…ng-is-not-intuitive

Bug: Framerate of videorecoding is not intuitive #303
@wurzelkuchen wurzelkuchen added this to the v5.1.0 milestone Nov 29, 2024
@wurzelkuchen wurzelkuchen added codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there and removed docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oomelianchuk oomelianchuk

Labels
bug codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging a pull request may close this issue.

Bug: Framerate of videorecoding is not intuitive #303 Xceptance/neodymium
2 participants
@wurzelkuchen @oomelianchuk