Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a function to stabilize test that are flaky due to page features that are not relevant for the test #148

Closed
occupant23 opened this issue Oct 9, 2020 · 4 comments · Fixed by #191
Assignees
Labels
codeDone The issue is rechecked for development branch docsDone The documentation for this issue was rechecked and merged to the develop branch feature Low Priority
Milestone

Comments

@occupant23
Copy link
Contributor

occupant23 commented Oct 9, 2020

I noticed, that the code like this

        try
        {
            $("#onetrust-accept-btn-handler").shouldBe(visible);
        }
        catch (ElementNotFound e)
        {
            overlayIsVisible = false;
        }

is/can be used in multiple projects, e.g. I built a custom method like this for a customer project. Wouldn't it be a good idea to extend SelenideAddons with methods to wait until or while some condition, without any exception throwing but just returning a boolean value as information whether the condition was fulfilled?

Originally posted by @oomelianchuk in https://github.com/Xceptance/neodymium-library/issue_comments/703550134

@occupant23 occupant23 added this to the backlog milestone Oct 9, 2020
georgkunze pushed a commit that referenced this issue Jun 4, 2021
georgkunze pushed a commit that referenced this issue Jun 4, 2021
georgkunze pushed a commit that referenced this issue Jun 4, 2021
georgkunze pushed a commit that referenced this issue Jun 7, 2021
georgkunze pushed a commit that referenced this issue Jun 14, 2021
@occupant23 occupant23 modified the milestones: backlog, v4.2.0 Jul 5, 2021
@occupant23 occupant23 added the docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop label Jul 5, 2021
@occupant23
Copy link
Contributor Author

@georgkunze Have you already added documentation regarding this feature to our wiki dev branch?

@georgkunze
Copy link

@georgkunze Have you already added documentation regarding this feature to our wiki dev branch?

I just checked. And there is no added documentatio for this feature.

occupant23 added a commit that referenced this issue Jul 5, 2021
…ilize-test-that-are-flaky-due-to-page-features-that-are-not-relevant-for-the-test

#148 Added optionalWaitUntilCondition and optionalWaitWhileCondition
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Jul 5, 2021
@occupant23 occupant23 assigned occupant23 and unassigned georgkunze Jul 5, 2021
@occupant23
Copy link
Contributor Author

Documentation needs to be added, Issue is ready for final test

@wurzelkuchen wurzelkuchen added docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made and removed docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop labels Apr 10, 2024
@wurzelkuchen wurzelkuchen modified the milestones: v4.2.0, backlog, v5.0.0 May 17, 2024
@AJakobi
Copy link
Contributor

AJakobi commented May 30, 2024

Added docu, ready for review

@AJakobi AJakobi added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop and removed docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made labels May 30, 2024
@wurzelkuchen wurzelkuchen added docsDone The documentation for this issue was rechecked and merged to the develop branch codeDone The issue is rechecked for development branch and removed docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeDone The issue is rechecked for development branch docsDone The documentation for this issue was rechecked and merged to the develop branch feature Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants