Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SelenideAddons.matchAttribute #146

Closed
occupant23 opened this issue Oct 9, 2020 · 4 comments
Closed

Deprecate SelenideAddons.matchAttribute #146

occupant23 opened this issue Oct 9, 2020 · 4 comments
Assignees
@occupant23
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop improvement Medium Priority
Milestone
v4.1.0

Comments

@occupant23
Copy link
Contributor

Deprecate the SelenideAddons.matchAttribute function since com.codeborne.selenide.Condition.attributeMatching does a similar job.
@occupant23 occupant23 added improvement docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop labels Oct 9, 2020
@occupant23 occupant23 added this to the v4.1.0 milestone Oct 9, 2020
@occupant23 occupant23 self-assigned this Oct 9, 2020
occupant23 pushed a commit that referenced this issue Oct 9, 2020
#146 - Deprecate SelenideAddons.matchAttribute
54d2efc
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Oct 9, 2020
@occupant23
Copy link
Contributor Author

Ready to recheck. I also exchanged an example function in the wiki to showcase another supported function instead.

@h-arlt
Copy link
Contributor

h-arlt commented Oct 19, 2020

Please see my comments on your commit.

occupant23 pushed a commit that referenced this issue Oct 20, 2020
#146 - Deprecate SelenideAddons.matchAttribute
4084851 
improved JavaDoc
@occupant23
Copy link
Contributor Author

Fixed them. Please review again.

@h-arlt
Copy link
Contributor

h-arlt commented Oct 21, 2020

Looks good to me.

@h-arlt h-arlt added the codeDone The issue is rechecked for development branch label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop improvement Medium Priority
Projects
None yet
Milestone
v4.1.0
Development

No branches or pull requests
2 participants
@h-arlt @occupant23