Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for ftp proxy #144

Closed
occupant23 opened this issue Sep 25, 2020 · 3 comments
Closed

Remove support for ftp proxy #144

occupant23 opened this issue Sep 25, 2020 · 3 comments
Assignees
@occupant23
Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there High Priority improvement
Milestone
v4.1.0

Comments

@occupant23
Copy link
Contributor

Chrome removed the support for FTP and SFTP proxy.
Remove the usage of those things from BrowserRunnerHelper and retest the proxy implementation.
@occupant23 occupant23 self-assigned this Sep 28, 2020
@occupant23 occupant23 added this to the v4.1.0 milestone Sep 28, 2020
occupant23 pushed a commit that referenced this issue Sep 28, 2020
#144 - Remove support for ftp proxy
d612858
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Sep 28, 2020
@occupant23
Copy link
Contributor Author

@h-arlt Please review this.

@h-arlt h-arlt added the codeDone The issue is rechecked for development branch label Oct 14, 2020
@occupant23 occupant23 assigned h-arlt and unassigned h-arlt Oct 16, 2020
@occupant23
Copy link
Contributor Author

@h-arlt Thanks :-)

@h-arlt
Copy link
Contributor

h-arlt commented Oct 19, 2020

(Still) works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there High Priority improvement
Projects
None yet
Milestone
v4.1.0
Development

No branches or pull requests
2 participants
@h-arlt @occupant23