Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print a one line Neodymium version information at runtime #139

Closed
rkl-xc opened this issue Sep 8, 2020 · 7 comments
Closed

Print a one line Neodymium version information at runtime #139

rkl-xc opened this issue Sep 8, 2020 · 7 comments
Assignees
@oomelianchuk
Labels
codeChangeRequired During recheck issues for this popped up and needs to be addressed feature Low Priority
Milestone
v4.1.0

Comments

@rkl-xc
Copy link
Contributor

rkl-xc commented Sep 8, 2020

Would be helpful to see the running Neodymium version once per launch to verify which neodymium-library is in use. I'd expect to see a line in the stdout saying:

[INFO] Running Xceptance Neodymium Library 4.0.0, see also https://github.com/Xceptance/neodymium-library
@occupant23 occupant23 added this to the v4.1.0 milestone Sep 24, 2020
@occupant23 occupant23 self-assigned this Sep 28, 2020
@occupant23 occupant23 added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels Sep 30, 2020
@occupant23
Copy link
Contributor

Logging will be don when instancing the NeodymiumRunner or the NeodymiumCucumberRunner.
Logging level is info as proposed.

Added a function Neodymium.getNeodymiumVersion() to retrieve the version for any reason needed.

occupant23 pushed a commit that referenced this issue Sep 30, 2020
#139 - print a one line Neodymium version information at runtime
064cecf
occupant23 pushed a commit that referenced this issue Sep 30, 2020
#139 - print a one line Neodymium version information at runtime
d2d9947 
added JavaDoc
@occupant23
Copy link
Contributor

documentation done

occupant23 pushed a commit that referenced this issue Oct 2, 2020
#139 - print a one line Neodymium version information at runtime
eb82363 
fixed LOGGER initialization
@oomelianchuk
Copy link
Contributor

IMO the changes are good, I have nothing to complain about

@rkl-xc
Copy link
Contributor Author

rkl-xc commented Oct 16, 2020 •
edited
Loading

I'd suppose to improve the version info output "Running a test using Neodymium Library" to transport some more information about the supplier (us) and the software itself. This could be:

Copyright (c) 2018, 2020, Xceptance Software Technologies GmbH, Germany
Neodymium Library <version>, <release date>, MIT License
Open Source best practice test automation library for Web applications
www.xceptance.com, github.com/Xceptance/neodymium-library

This seems to be very long, but it is more professional, than what is currently implemented.

@h-arlt
Copy link
Contributor

h-arlt commented Oct 19, 2020 •
edited
Loading

I'd suppose to improve the version info output "Running a test using Neodymium Library" to transport some more information about the supplier (us) and the software itself. This could be:

Copyright (c) 2018, 2020, Xceptance Software Technologies GmbH, Germany
Neodymium Library , , MIT License
Open Source best practice test automation library for Web applications
www.xceptance.com, github.com/Xceptance/neodymium-library

This seems to be very long, but it is more professional, than what is currently implemented.

According to the subject of this issue - and as long as this information is printed to the execution log - we should restrict it to a single line. Otherwise, analysing the logs in an automatic fashion might become tedious as most logging processors are line-oriented.

occupant23 pushed a commit that referenced this issue Oct 27, 2020
#139 - print a one line Neodymium version information at runtime
881dc9a 
Improved wording
@occupant23
Copy link
Contributor

I adapted the wording a little to:
This test uses Neodymium Library (version: ?.?.?), MIT License, more details on https://github.com/Xceptance/neodymium-library

@occupant23 occupant23 added codeDone The issue is rechecked for development branch feature and removed improvement labels Oct 27, 2020
@occupant23 occupant23 changed the title print a one line Neodymium version information at runtime Print a one line Neodymium version information at runtime Oct 27, 2020
@wurzelkuchen wurzelkuchen removed docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels Jun 21, 2024
@wurzelkuchen wurzelkuchen reopened this Jun 21, 2024
@wurzelkuchen
Copy link
Contributor

This is currently spamming the log a bit.
Three changes needed
a) only print it once, not for every test class
b) give it a toggle in the config
c) add it to the allure report environment

@wurzelkuchen wurzelkuchen added codeChangeRequired During recheck issues for this popped up and needs to be addressed and removed codeDone The issue is rechecked for development branch labels Jun 21, 2024
oomelianchuk added a commit that referenced this issue Jun 21, 2024
@oomelianchuk
reduce amount of Neo version logs, add Neo version to Allure #139
416a965
oomelianchuk added a commit that referenced this issue Jun 24, 2024
@oomelianchuk
add env information to allure #139
78b226c
wurzelkuchen added a commit that referenced this issue Jun 25, 2024
@wurzelkuchen
Merge pull request #256 from Xceptance/139-Print_a_one_line_Neodymium…
5ec0469 
…_version_information_at_runtime-cleanup

Reduce amount of Neo version logs, add Neo version to Allure #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oomelianchuk oomelianchuk

Labels
codeChangeRequired During recheck issues for this popped up and needs to be addressed feature Low Priority
Projects
None yet
Milestone
v4.1.0
Development

No branches or pull requests
5 participants
@wurzelkuchen @h-arlt @occupant23 @oomelianchuk @rkl-xc