Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open a HTML snippet with WebDriver #133

Closed
occupant23 opened this issue Aug 20, 2020 · 6 comments
Closed

Open a HTML snippet with WebDriver #133

occupant23 opened this issue Aug 20, 2020 · 6 comments
Assignees
@h-arlt @occupant23 @oomelianchuk
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature Medium Priority
Milestone
v4.0.0

Comments

@occupant23
Copy link
Contributor

Implement a function to open a HTML snippet using the current WebDriver.
@occupant23 occupant23 added this to the v3.7.0 milestone Aug 20, 2020
@occupant23 occupant23 self-assigned this Aug 20, 2020
occupant23 pushed a commit that referenced this issue Aug 20, 2020
#133: open a HTML snippet with WebDriver
689636d
@occupant23 occupant23 added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels Aug 20, 2020
@occupant23
Copy link
Contributor Author

@oomelianchuk Please recheck.

@oomelianchuk
Copy link
Contributor

I think everything is fine and clear

@occupant23 occupant23 added the codeDone The issue is rechecked for development branch label Aug 21, 2020
@h-arlt
Copy link
Contributor

h-arlt commented Aug 24, 2020

Please note that I've added a comment to your commit.

occupant23 pushed a commit that referenced this issue Aug 26, 2020
#133: changed implementation to use Base64 instead of file IO
f61dcf0
@occupant23 occupant23 removed the codeDone The issue is rechecked for development branch label Aug 26, 2020
@occupant23
Copy link
Contributor Author

@h-arlt Please recheck.

@h-arlt
Copy link
Contributor

h-arlt commented Aug 26, 2020

Looks goods to me and works like a charm.

@h-arlt h-arlt added the codeDone The issue is rechecked for development branch label Aug 26, 2020
@occupant23
Copy link
Contributor Author

documentation done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-arlt h-arlt

@occupant23 occupant23

@oomelianchuk oomelianchuk

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature Medium Priority
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@h-arlt @occupant23 @oomelianchuk