Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test code #128

Closed
occupant23 opened this issue Jul 21, 2020 · 0 comments · Fixed by #129
Closed

Improve test code #128

occupant23 opened this issue Jul 21, 2020 · 0 comments · Fixed by #129
Assignees
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there improvement Low Priority
Milestone

Comments

@occupant23
Copy link
Contributor

Exchange the expected parameter of the Test annotation with Assert.assertThrows within our test suite.
This reduces the risk of masking an error because the same error was thrown accidentally. Create a PR afterwards.

before:
@Test(expected = UIAssertionError.class

after:

// code before the Throwable is ecpected
Assert.assertThrows(UIAssertionError.class, () -> {
    // code that will produce the Throwable
});
@occupant23 occupant23 added this to the v3.7.0 milestone Jul 21, 2020
occupant23 added a commit that referenced this issue Jul 27, 2020
@occupant23 occupant23 linked a pull request Jul 27, 2020 that will close this issue
@occupant23 occupant23 added codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there codeDone The issue is rechecked for development branch labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there improvement Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants