Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error in SelenideAddonsTest #125

Closed
occupant23 opened this issue Jul 1, 2020 · 2 comments
Closed

Fix an error in SelenideAddonsTest #125

occupant23 opened this issue Jul 1, 2020 · 2 comments
Assignees
@occupant23 @oomelianchuk
Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there Medium Priority
Milestone
v4.0.0

Comments

@occupant23
Copy link
Contributor

There is an error due to an GDPR overlay.

Solution: Cancel the dialog before interacting with the site itself.
@occupant23 occupant23 self-assigned this Jul 1, 2020
@occupant23 occupant23 added this to the v3.7.0 milestone Jul 1, 2020
occupant23 pushed a commit that referenced this issue Jul 1, 2020
#125: Fix an error in SelenideAddonsTest
821f4df
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Jul 1, 2020
@occupant23
Copy link
Contributor Author

@oomelianchuk Please review and test.

@oomelianchuk
Copy link
Contributor

added Selenide.refresh() after closing the cookie dialog to make tests more stable. Few repetitive local test runs have proved, that presence of Selenide.refresh() at this place improves the test stability.

@occupant23 occupant23 added the codeDone The issue is rechecked for development branch label Jul 27, 2020
occupant23 pushed a commit that referenced this issue Sep 1, 2020
#125: removed closing the GDPR dialog since the overlay disappeared
76e936b
@occupant23 occupant23 mentioned this issue Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

@oomelianchuk oomelianchuk

Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there Medium Priority
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@occupant23 @oomelianchuk