Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce reuse counter for web driver/browser instances #124

Closed
jowerner opened this issue Jul 1, 2020 · 4 comments
Closed

Introduce reuse counter for web driver/browser instances #124

jowerner opened this issue Jul 1, 2020 · 4 comments
Assignees
@h-arlt @occupant23
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature Medium Priority
Milestone
v4.0.0

Comments

@jowerner
Copy link

jowerner commented Jul 1, 2020

Reusing browser instances for multiple tests is great as it can save a lot of test time. However, observations have shown that some browsers may get fatter and slower over time or even crash sporadically when being reused for many test cases. In these situations, a configurable reuse counter could help which controls how often a certain driver/browser instance is used before it is recreated freshly.
@occupant23 occupant23 self-assigned this Jul 27, 2020
@occupant23 occupant23 added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature Medium Priority labels Jul 27, 2020
@occupant23 occupant23 added this to the v3.7.0 milestone Jul 27, 2020
occupant23 pushed a commit that referenced this issue Jul 31, 2020
inital refactoring for #124, fixed a blocking bug in quitCachedBrowsers
2df1552
occupant23 pushed a commit that referenced this issue Jul 31, 2020
#124: added max reuse functionality
2384639
occupant23 pushed a commit that referenced this issue Jul 31, 2020
#124: added unit tests for max reuse functionality
30b90c0
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: added documentation to neodymium.properties
8427e5d
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: rename a function and removed default constructor
96b117d
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: change a variable naming at every occurence
bb4ae10
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: renamed test case
5420a48
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: renamed test case
f52c785
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: refactured teardonw method and adjusted the signature of a help…
ef1ad26 
…er function
occupant23 pushed a commit that referenced this issue Aug 10, 2020
#124: added documentation and improved tests
6392447
occupant23 added a commit that referenced this issue Aug 11, 2020
@occupant23
#124: Update documentation config/neodymium.properties
35949bc 
Co-authored-by: Christoph Keiner <c.keiner@xceptance.net>
occupant23 added a commit that referenced this issue Aug 11, 2020
@occupant23
Merge pull request #130 from Xceptance/#124-reuse-counter-and-max-reuse
826bf47 
#124 reuse counter and max reuse
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Aug 21, 2020
occupant23 pushed a commit that referenced this issue Aug 26, 2020
#124: changed the scope of the caching map to class instance, since t…
8216d75 
…he class itself is already a singleton
occupant23 pushed a commit that referenced this issue Aug 26, 2020
#124: improved getters for proxy and webDriver
73f51f7
@occupant23
Copy link
Contributor

@h-arlt Please recheck.

@h-arlt
Copy link
Contributor

h-arlt commented Aug 26, 2020 •
edited
Loading

Besides two small improvements regarding documentation (see my comments at commit 826bf47) code looks good to me and works as expected.

occupant23 pushed a commit that referenced this issue Aug 27, 2020
#124: refactored quitCachedBrowsers
962e5e4
occupant23 pushed a commit that referenced this issue Aug 27, 2020
#124: renamed a method and adjusted JavaDoc
5c94ec1
occupant23 pushed a commit that referenced this issue Aug 27, 2020
#124: updated JavaDoc
8076fa4
occupant23 pushed a commit that referenced this issue Aug 27, 2020
#124: renamed method
effa81e
@h-arlt
Copy link
Contributor

h-arlt commented Aug 27, 2020

Well done my friend ;-)

@h-arlt h-arlt added the codeDone The issue is rechecked for development branch label Aug 27, 2020
@occupant23
Copy link
Contributor

documentation for configuration and base functions done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-arlt h-arlt

@occupant23 occupant23

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature Medium Priority
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@jowerner @h-arlt @occupant23