Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support global browser settings #123

Closed
ckeiner opened this issue May 11, 2020 · 9 comments
Closed

Support global browser settings #123

ckeiner opened this issue May 11, 2020 · 9 comments
Assignees
@occupant23
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop improvement Low Priority
Milestone
v4.1.0

Comments

@ckeiner
Copy link

ckeiner commented May 11, 2020

Currently, I have to manually set my browser settings for each browser configuration. While this often helps, it can also become tedious if I want to set the same value for each browser configuration. This often happens for the headless mode which I always want to stay the same for each browser.

It would really help if I had some way to set the same value for all browser configurations, either via a global browser configuration which get overwritten by specific ones or by being able to refer to another property, e.g.

browser.headless = true
browser.<config>.headless = browser.headless
@occupant23 occupant23 modified the milestones: backlog, v4.1.0 Sep 1, 2020
occupant23 pushed a commit that referenced this issue Sep 29, 2020
#123 - Support global browser settings
21e74a4
@occupant23 occupant23 self-assigned this Sep 29, 2020
@occupant23 occupant23 added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there Low Priority labels Sep 29, 2020
@occupant23
Copy link
Contributor

code and documentation ready for test

@oomelianchuk
Copy link
Contributor

IMO the changes are good, I have nothing to complain about

@occupant23
Copy link
Contributor

@ckeiner Please have a look if this suits your needs.

@ckeiner
Copy link
Author

ckeiner commented Oct 20, 2020

  • Global Settings:

    • There may be limited use cases for such cases, but browserResolutionand screenResolution should also be configurable globally.
    • IMO, even arguments might be valid global settings if you do not plan to mix different browsers.

  • Wiki Documentation

    • Did you happen to switch the possible values of pageLoadStrategy with the ones from acceptInsecureCerts?
      • If not, what does each value mean?

  • Documentation of the browser.properties:

    • What is <short name> and what are non-special values (i.e. everything besides "global")?
    • Why is it named <short name> and not <configuration tag> like it is in the wiki documentation?
    • A sample for a global browser profile would be good, even if it is commented out.

@ckeiner
Copy link
Author

ckeiner commented Oct 20, 2020

See 21e74a4#r43402070
As well as 21e74a4#r43402047

@occupant23
Copy link
Contributor

Global Settings:

  • Added browserResolution.
  • Wont add: screenResolution (is only relevant for test environments)
  • Wont add: arguments (they are specific to the used browser and this could cause errors that would be hard to find)

Wiki Documentation: fixed it

Documentation of the browser.properties: fixed it

occupant23 pushed a commit that referenced this issue Oct 20, 2020
#123 - Support global browser settings
4f998b5 
Small changes after review, added browser resolution as global browser setting
@occupant23
Copy link
Contributor

Can be rechecked again.

@ckeiner
Copy link
Author

ckeiner commented Oct 21, 2020

Except a minor grammatical error (4f998b5#r43434237) which was in before, everything looks fine to me.

@ckeiner ckeiner added the codeDone The issue is rechecked for development branch label Oct 21, 2020
occupant23 pushed a commit that referenced this issue Oct 21, 2020
#123 - Support global browser settings
122856a 
fixed a typo
@occupant23
Copy link
Contributor

done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop improvement Low Priority
Projects
None yet
Milestone
v4.1.0
Development

No branches or pull requests
3 participants
@occupant23 @ckeiner @oomelianchuk