Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Maven dependencies as far as possible #119

Closed
occupant23 opened this issue Apr 3, 2020 · 5 comments
Closed

Update Maven dependencies as far as possible #119

occupant23 opened this issue Apr 3, 2020 · 5 comments
Assignees
@h-arlt @occupant23
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there Medium Priority update-dependency
Milestone
v4.0.0

Comments

@occupant23
Copy link
Contributor

No description provided.

@occupant23 occupant23 added this to the v3.7.0 milestone Apr 3, 2020
occupant23 pushed a commit that referenced this issue Jun 17, 2020
#119: update dependencies browserup-proxy
e8157e2
occupant23 pushed a commit that referenced this issue Jun 17, 2020
#119: update dependencies - Selenide, fixed deprecated usage of GSON
9a7db47
occupant23 pushed a commit that referenced this issue Jun 17, 2020
#119: update dependencies - allure, cucumber, log4j, guava, owner
82c0f6a
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Jun 17, 2020
@occupant23
Copy link
Contributor Author

Cucumber could only be updated to 5.7.0 since Allure doesn't support the next major release (6) yet. Needs to be rechecked prior the release.

@occupant23 occupant23 self-assigned this Jul 21, 2020
@h-arlt
Copy link
Contributor

h-arlt commented Aug 24, 2020

Found some updates:

  • Allure v2.13.5
  • Selenide v5.14.2
  • Commons Text v1.9
  • Commons Lang3 v.3.11

I also noticed that browserup-proxy-mitm and littleproxy are explicitly specified as dependencies although they are dependencies of browserup-proxy-core. Was this done intentionally?

@occupant23
Copy link
Contributor Author

Updated the following:
Allure v2.13.5
Selenide v5.14.2
Commons Text v1.9
Commons Lang3 v.3.11

Removed:
littleproxy

The browserup-proxy-mitm dependencies is needed at compile time and only provided at runtime by browserup-proxy-core.

@occupant23
Copy link
Contributor Author

@h-arlt Please recheck.

occupant23 pushed a commit that referenced this issue Aug 26, 2020
#119: updated dependencies and removed a unneeded explicit dependency
81e95f8
@h-arlt
Copy link
Contributor

h-arlt commented Aug 27, 2020

Look goods to me.

FYI scope compile is default for Maven dependencies so there is no real need to declare dependency browserup-proxy-mitm for scope compile explicitly.

@h-arlt h-arlt added the codeDone The issue is rechecked for development branch label Aug 27, 2020
occupant23 pushed a commit that referenced this issue Aug 27, 2020
#119: removed scope for dependency since this is the default
e2e34b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-arlt h-arlt

@occupant23 occupant23

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there Medium Priority update-dependency
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@h-arlt @occupant23