fix alert consumers #7

michaelolo24 · 2021-08-18T01:24:28Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…iew-2

michaelolo24 · 2021-08-18T01:28:33Z

x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx

@@ -232,7 +227,7 @@ const TGridIntegratedComponent: React.FC<TGridIntegratedProps> = ({
    loading,
    { events, loadPage, pageInfo, refetch, totalCount = 0, inspect },
  ] = useTimelineEvents({
-    alertConsumers: SECURITY_ALERTS_CONSUMERS,


We use this table for the hosts page as well, so just passing this value in on the alerts table and leaving it out on the host page

michaelolo24 · 2021-08-18T01:30:49Z

x-pack/plugins/security_solution/public/detections/components/alerts_table/index.tsx

@@ -380,10 +382,11 @@ export const AlertsTableComponent: React.FC<AlertsTableComponentProps> = ({

  return (
    <StatefulEventsViewer
+      alertConsumers={SECURITY_SOLUTION_ALERT_CONSUMERS}


pass alertConsumers to define consumers for the alert table

michaelolo24 · 2021-08-18T01:31:37Z

x-pack/plugins/security_solution/public/common/components/events_viewer/index.tsx

@@ -221,7 +222,7 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
      <DetailsPanel
        alertConsumers={alertConsumers}
        browserFields={browserFields}
-        entityType={EntityType.ALERTS}


Detail panel should use whatever entityType is passed in for hosts vs alerts page

michaelolo24 · 2021-08-18T01:32:30Z

x-pack/plugins/security_solution/public/common/components/events_viewer/index.tsx

@@ -155,6 +155,7 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
          {tGridEnabled ? (
            timelinesUi.getTGrid<'embedded'>({
              id,
+              alertConsumers,


pass alertConsumers for the alert table, but left out of the table in events_query_tab_body.tsx

michaelolo24 · 2021-08-18T01:33:14Z

x-pack/plugins/security_solution/public/common/components/alerts_viewer/alerts_table.tsx

@@ -106,6 +107,7 @@ const AlertsTableComponent: React.FC<Props> = ({

  return (
    <StatefulEventsViewer
+      alertConsumers={SECURITY_SOLUTION_ALERT_CONSUMERS}


Pass it to the alertTable

michaelolo24 · 2021-08-18T01:33:44Z

x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx

@@ -234,7 +230,7 @@ export const CaseView = React.memo(({ caseId, subCaseId, userCanCrud }: Props) =
        showAlertDetails,
        subCaseId,
        timelineIntegration: {
-          alertConsumers: ALERT_CONSUMER,
+          alertConsumers: SECURITY_SOLUTION_ALERT_CONSUMERS,


pass consumers for the timelineIntegration for cases

michaelolo24 · 2021-08-18T01:33:54Z

x-pack/plugins/security_solution/common/constants.ts

@@ -310,3 +311,5 @@ export const showAllOthersBucket: string[] = [
 export const ELASTIC_NAME = 'estc';

 export const TRANSFORM_STATS_URL = `/api/transform/transforms/${metadataTransformPattern}-*/_stats`;
+
+export const SECURITY_SOLUTION_ALERT_CONSUMERS: AlertConsumers[] = [AlertConsumers.SIEM];


use a shared constant

fixes [#8](elastic/observability-accessibility#8) fixes [#7](elastic/observability-accessibility#7) ## Summary Fixes APM breadcrumbs on serverless | Serverless | Stateful | |---|---| | <img width="700px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="800px" alt="image" src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">| | <img width="500px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/cb8a39e2-ca33-4cf9-a8ac-4c84566d092d">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/151a3a9c-c81e-4558-9d00-e695e3d1d79c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/2562e96f-d5e4-4aa4-a221-6721f8995883">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/8d877d11-8c3f-4ac5-8146-6a11125eae7c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/36e588cb-4c18-4d66-a2c6-f0e66392f708">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/14253196-06de-4343-811f-61aa31ea0d1e">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/0cdfc83f-6545-433f-8c14-5bbf2a581175">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/89a58e2b-2cef-4188-b2be-f359ba6890db">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/f15e767f-5b60-4485-ac71-7b6fd850ec50">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/a0f7bfae-bfda-4f49-b92a-e736d80fea4c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/680db8ab-58b8-454b-a0d7-6e1681dbe616">| ### How to test #### Serverless - Start a local ES serverless instance: `yarn es serverless --projectType=oblt --ssl -k/--insecure` - Start a local Kibana serverless instance: ` yarn start --serverless=oblt --no-ssl` - Run some synthtrace scenarios - `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601` - `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601` - Navigate to Applications and click through the links ### Stateful - Start a local ES and Kibana instance - Run the some synthtrace scenarios: - `node scripts/synthtrace mobile.ts --live` - `node scripts/synthtrace service_map.ts --live` - Navigate to Applications and click through the links --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Merge branch 'master' of github.com:elastic/kibana into rac-summary-v…

b6a37b6

…iew-2

michaelolo24 commented Aug 18, 2021

View reviewed changes

XavierM force-pushed the rac-summary-view-2 branch from b6a37b6 to 680ec52 Compare August 18, 2021 01:52

fix alert consumers

f136bea

michaelolo24 force-pushed the remove-unnecessary-consumers branch from 510a100 to f136bea Compare August 18, 2021 02:21

michaelolo24 closed this Aug 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix alert consumers #7

fix alert consumers #7

michaelolo24 commented Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

michaelolo24 Aug 18, 2021

fix alert consumers #7

fix alert consumers #7

Conversation

michaelolo24 commented Aug 18, 2021

Summary

Checklist

For maintainers

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 18, 2021

Choose a reason for hiding this comment