Skip to content

Commit

Permalink
updated accessibility based on report
Browse files Browse the repository at this point in the history
  • Loading branch information
derrickhwang21 committed Feb 8, 2019
1 parent 1738c68 commit 3a464d9
Show file tree
Hide file tree
Showing 10 changed files with 55 additions and 2 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ Notifications | When a sighting is created, all users will receive a notificatio
7. First build the application from the CLI using: `./gradlew build`.
8. Run the application from the CLI using: `./gradlew bootrun`.

## Accessibility Scanner Report
### View Reports:
* [Accessibility Report 02/07/2019](assets/accessibility_report/accessibility_report_0202219)

## Credits, Sources, & Technologies
### Technologies:
Android Studios, Java, Firebase Services, Google Play, Glide, Espresso Testing, Git, GitHub
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/hwang/xsighting/MainActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@
import androidx.recyclerview.widget.RecyclerView;

import android.content.Intent;
import android.graphics.Color;
import android.os.Bundle;
import android.util.Log;
import android.view.MenuItem;
import android.widget.Toast;
import android.widget.Toolbar;

import com.firebase.ui.auth.AuthUI;
import com.firebase.ui.auth.IdpResponse;
Expand Down Expand Up @@ -58,7 +60,6 @@ protected void onCreate(Bundle savedInstanceState) {

// User is signed in
Task<GetTokenResult> token = user.getIdToken(false);

setNavigation();
Log.i(TAG, user.toString());
} else {
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/layout/activity_create_sighting.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@
android:layout_marginStart="8dp"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:paddingTop="6dp"
android:paddingBottom="6dp"
android:ems="10"
android:inputType="textMultiLine"
android:hint="@string/include_color_shape_of_object_sounds_etc"
Expand Down
10 changes: 9 additions & 1 deletion app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,22 @@
<!-- Customize your theme here. -->
<item name="colorPrimary">@color/colorPrimary</item>
<item name="colorPrimaryDark">@color/colorPrimaryDark</item>
<item name="colorAccent">@color/colorWhiteBackground</item>
<item name="colorAccent">@color/colorPrimaryDark</item>
<item name="android:windowBackground">@color/colorOminous</item>
<item name="android:fontFamily">monospace</item>
<item name="android:textColorPrimary">@color/colorPrimaryDark</item>
<item name="android:textColorSecondary">@android:color/black</item>
<item name="actionMenuTextColor">@android:color/black</item>
<item name="toolbarStyle">@style/CustomToolBarStyle</item>

</style>

<style name="CustomToolBarStyle" parent="@style/Widget.AppCompat.Toolbar">
<item name="titleTextColor">@color/colorPrimaryDark</item>
<item name="colorControlNormal">@color/colorPrimaryDark</item>
<item name="subtitleTextAppearance">@color/colorPrimaryDark</item>
<item name="titleTextAppearance">@color/colorPrimaryDark</item>
</style>


</resources>
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
The following is a list of opportunities to improve the accessibility of XSighting. Each item corresponds to an outlined area on the attached screenshot.

Text contrast
[56,222][359,315]
The item's text contrast ratio is 1.43. This ratio is based on an estimated foreground color of #FFFFFF and an estimated background color of #F1D592. Consider increasing this item's text contrast ratio to 3.00 or greater.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
The following is a list of opportunities to improve the accessibility of XSighting. Each item corresponds to an outlined area on the attached screenshot.

Text contrast
[252,222][555,315]
The item's text contrast ratio is 1.43. This ratio is based on an estimated foreground color of #FFFFFF and an estimated background color of #F1D592. Consider increasing this item's text contrast ratio to 3.00 or greater.

Text contrast
com.hwang.xsighting:id/report_description
The item's text contrast ratio is 2.68. This ratio is based on an estimated foreground color of #9E9E9E and an estimated background color of #FFFFFF. Consider increasing this item's text contrast ratio to 3.00 or greater.

Touch target
com.hwang.xsighting:id/report_description
This item's height is 45dp. Consider making the height of this touch target 48dp or larger.

Image contrast
[0,171][196,367]
The image's contrast ratio is 1.43. This ratio is based on an estimated foreground color of #FFFFFF and an estimated background color of #F1D592. Consider increasing this ratio to 3.00 or greater.

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
The following is a list of opportunities to improve the accessibility of XSighting. Each item corresponds to an outlined area on the attached screenshot.

Text contrast
[252,222][555,315]
The item's text contrast ratio is 1.43. This ratio is based on an estimated foreground color of #FFFFFF and an estimated background color of #F1D592. Consider increasing this item's text contrast ratio to 3.00 or greater.

Text contrast
com.hwang.xsighting:id/postTitle
The item's text contrast ratio is 1.06. This ratio is based on an estimated foreground color of #000000 and an estimated background color of #010B13. Consider increasing this item's text contrast ratio to 3.00 or greater.

Image contrast
[0,171][196,367]
The image's contrast ratio is 1.43. This ratio is based on an estimated foreground color of #FFFFFF and an estimated background color of #F1D592. Consider increasing this ratio to 3.00 or greater.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 3a464d9

Please sign in to comment.