Add support for unknown transactions #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkramer44
commented
Nov 2, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/UnlModify.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
============================================
- Coverage 92.02% 92.01% -0.01%
- Complexity 1843 1848 +5
============================================
Files 382 383 +1
Lines 5115 5125 +10
Branches 435 435
============================================
+ Hits 4707 4716 +9
- Misses 272 273 +1
Partials 136 136 ☔ View full report in Codecov by Sentry. |
sappenin
requested changes
Nov 5, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/AmmBid.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/TransactionDeserializer.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/AmmBid.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Transaction.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/TransactionType.java
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/TransactionTypeTests.java
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/UnlModifyJsonTests.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/UnlModify.java
Outdated
Show resolved
Hide resolved
sappenin
approved these changes
Feb 3, 2025
exp0nge
reviewed
Feb 12, 2025
| @@ -62,7 +62,7 @@ static ImmutableUnlModify.Builder builder() { | |||
| */ | |||
| @Override | |||
| @JsonProperty("Account") | |||
| @Value.Derived | |||
| @Value.Default | |||
There was a problem hiding this comment.
Nice catch - I'll take a look at this one tonight.
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field to
TransactioncalledunknownFields, which is annotated with@JsonAnySetter. This tells Jackson to populateunknownFieldswith any JSON fields that are unmapped in the immutable.This allow for two things:
UnknownTransaction, which only has common fields +unknownFields, which allows any version of xrpl4j that containsUnknownTransactionto deserialize an unsupported transaction type from JSON