Add ledger entries from #473

Fixes #473
XRPLF · Aug 23, 2024 · d2c6596 · d2c6596
1 parent a486fc5
commit d2c6596
Show file tree

Hide file tree

Showing 4 changed files with 670 additions and 26 deletions.
diff --git a/...ore/src/test/java/org/xrpl/xrpl4j/model/transactions/NegativeTransactionMetadataTest.java b/...ore/src/test/java/org/xrpl/xrpl4j/model/transactions/NegativeTransactionMetadataTest.java
@@ -77,38 +77,22 @@ void deserializeLedger354575() throws IOException {
     );
   }
 
-  /**
-   * This test validates that the ledger 87704323 and all of its transactions and metadata are handled correctly, even
-   * in the presence of negative XRP or IOU amounts.
-   */
-  @Test
-  void deserializeOfferCreateWithNegativeValues() throws IOException {
-    File jsonFile = new File(
-      "src/test/resources/negative-balance-ledgers/txresult-offercreate-withnegatives.json"
-    );
-
-    TransactionResult<OfferCreate> transactionResult = objectMapper.readValue(
-      jsonFile, objectMapper.getTypeFactory().constructParametricType(TransactionResult.class, OfferCreate.class)
-    );
-
-    assertThat(transactionResult.metadata().isPresent()).isTrue();
-    transactionResult.metadata().ifPresent(this::handleTransactionMetadata);
-  }
-
   /**
    * This test validates that the ledger 87704323 and all of its transactions and metadata are handled correctly, even
    * in the presence of negative XRP or IOU amounts.
    */
   @ParameterizedTest
   @ValueSource(strings = {
-    "ledger-result-346610.json",
-    "ledger-result-340231.json",
-    "ledger-result-346610.json",
-    "ledger-result-350621.json",
-    "ledger-result-353674.json",
-    "ledger-result-354496.json",
-    "ledger-result-354575.json",
-    "ledger-result-354579.json",
+    "ledger-result-309936.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/473
+    "ledger-result-309937.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/473
+    "ledger-result-329212.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-340231.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-346610.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-350621.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-353674.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-354496.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-354575.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
+    "ledger-result-354579.json", // <-- See https://github.com/XRPLF/xrpl4j/issues/474
     "ledger-result-87704323.json",
     "ledger-result-90150378.json",
     "ledger-result-90156059.json"
@@ -128,6 +112,24 @@ void deserializeLedgerResultWithNegativeAmounts(String ledgerResultFileName) thr
     });
   }
 
+  /**
+   * This test validates that the ledger 87704323 and all of its transactions and metadata are handled correctly, even
+   * in the presence of negative XRP or IOU amounts.
+   */
+  @Test
+  void deserializeOfferCreateWithNegativeValues() throws IOException {
+    File jsonFile = new File(
+      "src/test/resources/negative-balance-ledgers/txresult-offercreate-withnegatives.json"
+    );
+
+    TransactionResult<OfferCreate> transactionResult = objectMapper.readValue(
+      jsonFile, objectMapper.getTypeFactory().constructParametricType(TransactionResult.class, OfferCreate.class)
+    );
+
+    assertThat(transactionResult.metadata().isPresent()).isTrue();
+    transactionResult.metadata().ifPresent(this::handleTransactionMetadata);
+  }
+
   private void handleTransactionMetadata(final TransactionMetadata transactionMetadata) {
     Objects.requireNonNull(transactionMetadata);