Fix unit test

XRPLF · Aug 22, 2024 · 374d7d6 · 374d7d6
1 parent a1a20e2
commit 374d7d6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java b/xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
@@ -92,11 +92,11 @@ private static void assertXrpIsValid(String amount) {
     if (!value.equals(BigDecimal.ZERO)) {
       if (value.signum() < 0) { // `value` is negative
         if (value.compareTo(MAX_NEGATIVE_XRP) > 0 || value.compareTo(MIN_DROPS) < 0) {
-          throw new IllegalArgumentException(amount + " is an illegal amount");
+          throw new IllegalArgumentException(String.format("%s is an illegal amount", amount));
         }
       } else { // `value` is positive
         if (value.compareTo(MIN_XRP) < 0 || value.compareTo(MAX_DROPS) > 0) {
-          throw new IllegalArgumentException(amount + " is an illegal amount");
+          throw new IllegalArgumentException(String.format("%s is an illegal amount", amount));
         }
       }
     }
@@ -181,9 +181,7 @@ public AmountType fromJson(JsonNode value) throws JsonProcessingException {
     result.append(currency);
     result.append(issuer);
 
-    return new
-
-      AmountType(result);
+    return new AmountType(result);
   }
 
   private UnsignedByteArray getAmountBytes(BigDecimal number) {

diff --git a/xrpl4j-core/src/test/java/org/xrpl/xrpl4j/codec/binary/types/AmountTypeTest.java b/xrpl4j-core/src/test/java/org/xrpl/xrpl4j/codec/binary/types/AmountTypeTest.java
@@ -23,6 +23,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
+import com.fasterxml.jackson.core.JsonParseException;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.provider.Arguments;
@@ -124,9 +125,19 @@ void encodeDecodePositiveXrpAmount() throws JsonProcessingException {
   @Test
   void encodeOutOfBounds() {
     // Positive
-    assertThrows(IllegalArgumentException.class, () -> codec.fromJson("416345785D8A0001"));
+    {
+      IllegalArgumentException thrownError = assertThrows(
+        IllegalArgumentException.class, () -> codec.fromJson("100000000000000001")
+      );
+      assertThat(thrownError.getMessage()).isEqualTo("100000000000000001 is an illegal amount");
+    }
     // Negative
-    assertThrows(IllegalArgumentException.class, () -> codec.fromJson("-416345785D8A0001"));
+    {
+      IllegalArgumentException thrownError = assertThrows(
+        IllegalArgumentException.class, () -> codec.fromJson("-100000000000000001")
+      );
+      assertThat(thrownError.getMessage()).isEqualTo("-100000000000000001 is an illegal amount");
+    }
   }
 
   @Test