Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate interactive tutorials #2325

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Jan 6, 2024

  • Fix most Markdoc errors caused by interactive tutorials
  • Migrate interactive tutorials to Redocly-compatible syntax
  • Debug issues with running tutorials after switching pages (they work fine after a page refresh but not always if you navigate to them). window.onRouteChange was supposed to fix this but it seems like it might not have fully.
    • Update: Redocly has confirmed this a bug on their end. To be fixed in an upcoming release.
  • Out of scope for now: allow network selection (probably using a custom markdoc function)
  • Out of scope for now: Unify XRPLoader with component used by WS tool

mDuo13 added 2 commits January 5, 2024 15:17
Attempt migrating interactive tutorial again

Migrate interactive tutorial snippet syntax

Interactive tutorials: partially migrate send-xrp, no-freeze to new syntax

Fix Send XRP interactive tutorial

Interactive tutorials: fixes for Redocly incl. localization challenges

Interactive tutorials: switch defaultValue back to value in anticipation of Redocly bugfix

Fix document.ready→window.onRouteChange, cyclers, etc. in interactive
tutorials.
@mDuo13 mDuo13 added this to the Toolchain-Migration-Redocly milestone Jan 6, 2024
@mDuo13 mDuo13 merged commit 9ec14c4 into XRPLF:redocly-migration Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant