Migrate the faucet page to Redocly #2243
Conversation
|
Will take this out of draft when done, wanted to open this as a PR so that work in progress could be used as a reference for others :) |
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
JST5000
changed the title
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
|
TODO before merging: Double check that the link from the top nav has a nice name for the page. (As opposed to a filename) |
|
Remaining to fix:
|
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
There was a problem hiding this comment.
It's weird that the faucet page doesn't have a sidebar even though it's listed in the sidebar. I wonder if we need to do something custom with the template to add it explicitly.
Mostly works but I would like to reduce the scope of the PR a little to reduce merge conflicts.
content/@i18n/ja/concepts/networks-and-servers/parallel-networks.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks like there are still some changes in this diff that are unrelated to the task at hand. If you can rebase to squash/drop as much of those as possible, that'll make the merging process easier. (We're going to have to rebase the redocly-migration branch onto the latest master after merging these, possibly more than once, so I want to keep each PR as constrained as possible, to minimize complications there.)
| @@ -0,0 +1,28 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe put this file into a data folder or something
There was a problem hiding this comment.
I think it's useful to keep the data near where it's used in this case since it's super related to the test & there's not many files so it doesn't clutter a reader's ability to tell what all the files are for / doing.
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
1 similar comment
|
Link check report. 553607 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/jm-faucets/ |
* Get basic HTML loading for faucet page * Add xrpl.js implementation * Add sidebar and fix throbber * Add translates * Try to format sidebar * Fix formatting * Support xrpl.js * Fix links * Comment out XRPLGuard for now * Make AMM Devnet faucet work * Improve readability * Update all instances of link + fix topnav * Remove unnecessary file * Use a more current version of xrpl * Add missing loader while keys are generating * Type with xrpl and remove unnecessary script * Use string interpolation instead of multiple trans * Move faucets into a json file * Remove the old faucet code * Use xrpl-beta directly * Use dropsToXRP * Support hooks natively * Remove AMM-Devnet * Revert changes to link path * Revert link changes pt 2 * Revert pt 3 * Use XRPLoader for loading icon * Fix small mistakes * Remove unnecessary changes
* Get basic HTML loading for faucet page * Add xrpl.js implementation * Add sidebar and fix throbber * Add translates * Try to format sidebar * Fix formatting * Support xrpl.js * Fix links * Comment out XRPLGuard for now * Make AMM Devnet faucet work * Improve readability * Update all instances of link + fix topnav * Remove unnecessary file * Use a more current version of xrpl * Add missing loader while keys are generating * Type with xrpl and remove unnecessary script * Use string interpolation instead of multiple trans * Move faucets into a json file * Remove the old faucet code * Use xrpl-beta directly * Use dropsToXRP * Support hooks natively * Remove AMM-Devnet * Revert changes to link path * Revert link changes pt 2 * Revert pt 3 * Use XRPLoader for loading icon * Fix small mistakes * Remove unnecessary changes
* Get basic HTML loading for faucet page * Add xrpl.js implementation * Add sidebar and fix throbber * Add translates * Try to format sidebar * Fix formatting * Support xrpl.js * Fix links * Comment out XRPLGuard for now * Make AMM Devnet faucet work * Improve readability * Update all instances of link + fix topnav * Remove unnecessary file * Use a more current version of xrpl * Add missing loader while keys are generating * Type with xrpl and remove unnecessary script * Use string interpolation instead of multiple trans * Move faucets into a json file * Remove the old faucet code * Use xrpl-beta directly * Use dropsToXRP * Support hooks natively * Remove AMM-Devnet * Revert changes to link path * Revert link changes pt 2 * Revert pt 3 * Use XRPLoader for loading icon * Fix small mistakes * Remove unnecessary changes
* Get basic HTML loading for faucet page * Add xrpl.js implementation * Add sidebar and fix throbber * Add translates * Try to format sidebar * Fix formatting * Support xrpl.js * Fix links * Comment out XRPLGuard for now * Make AMM Devnet faucet work * Improve readability * Update all instances of link + fix topnav * Remove unnecessary file * Use a more current version of xrpl * Add missing loader while keys are generating * Type with xrpl and remove unnecessary script * Use string interpolation instead of multiple trans * Move faucets into a json file * Remove the old faucet code * Use xrpl-beta directly * Use dropsToXRP * Support hooks natively * Remove AMM-Devnet * Revert changes to link path * Revert link changes pt 2 * Revert pt 3 * Use XRPLoader for loading icon * Fix small mistakes * Remove unnecessary changes
* Get basic HTML loading for faucet page * Add xrpl.js implementation * Add sidebar and fix throbber * Add translates * Try to format sidebar * Fix formatting * Support xrpl.js * Fix links * Comment out XRPLGuard for now * Make AMM Devnet faucet work * Improve readability * Update all instances of link + fix topnav * Remove unnecessary file * Use a more current version of xrpl * Add missing loader while keys are generating * Type with xrpl and remove unnecessary script * Use string interpolation instead of multiple trans * Move faucets into a json file * Remove the old faucet code * Use xrpl-beta directly * Use dropsToXRP * Support hooks natively * Remove AMM-Devnet * Revert changes to link path * Revert link changes pt 2 * Revert pt 3 * Use XRPLoader for loading icon * Fix small mistakes * Remove unnecessary changes
Migrating this page: https://xrpl.org/xrp-testnet-faucet.html
Steps to migrate
Visible pieces of the page to migrate