Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JA] Move files to a dir compatible with Redocly #2206

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[JA] Move files to a dir compatible with Redocly #2206

merged 2 commits into from
Oct 10, 2023

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Oct 9, 2023

The new folder will be compatible with both Dactyl and Redocly when it comes to loading the Japanese translation for a given page.

Snippets are not moved for now because importing them would require more complex changes to the actual Markdown pages, and wouldn't be cross-compatible anyway (Redocly uses slightly different 'partial' rather than 'include' syntax.)

Note that the preview on GitHub Pages doesn't work properly for Japanese and never has. However, I built locally and confirmed that the site still renders successfully with no broken links.

Using git to compare the output from building before/after these changes, I confirmed that the only differences were that the "Edit on GitHub" links were updated to match the source files' new locations.

The new folder will be compatible with both Dactyl and Redocly when it
comes to loading the Japanese translation for a given page.

Snippets are not moved for now because importing them would require
more complex changes to the actual Markdown pages, and wouldn't be
cross-compatible anyway (Redocly uses slightly different 'partial'
rather than 'include' syntax.)
@mDuo13 mDuo13 added the organization Information architecture, restructuring, interlinking, etc. label Oct 9, 2023
@mDuo13 mDuo13 added this to the Toolchain-Migration-Redocly milestone Oct 9, 2023
@mDuo13 mDuo13 requested a review from tequdev October 9, 2023 18:38
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Link check report. 545635 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/migrate_ja/

Style Report

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Link check report. 545635 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/migrate_ja/

Style Report

@mDuo13 mDuo13 merged commit 35f267b into master Oct 10, 2023
@mDuo13 mDuo13 deleted the migrate_ja branch October 10, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organization Information architecture, restructuring, interlinking, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants