Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated build instructions and add redirects to BUILD.md #1789

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Remove outdated build instructions and add redirects to BUILD.md #1789

merged 3 commits into from
Mar 8, 2023

Conversation

oeggert
Copy link
Collaborator

@oeggert oeggert commented Mar 3, 2023

With the move to Conan in 1.10.0, the build from source instructions are now invalid. Redirecting to the build instructions on the stable branch of rippled.

@oeggert oeggert added the content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts label Mar 3, 2023
@oeggert oeggert self-assigned this Mar 3, 2023
@oeggert oeggert requested a review from mDuo13 March 3, 2023 19:41
@oeggert
Copy link
Collaborator Author

oeggert commented Mar 3, 2023

@mDuo13 The redirects aren't automatically redirecting for the English version of pages, but works fine for the Japanese ones. I'm not sure if I'm doing something wrong with the dactyl config?

@oeggert oeggert mentioned this pull request Mar 3, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Link check report. 470626 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/build-direction-redirects/

Style Report

@intelliot
Copy link
Contributor

We may still need instructions/information specific to Reporting Mode

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Link check report. 470626 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/build-direction-redirects/

Style Report

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Link check report. 471512 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/build-direction-redirects/

Style Report

@oeggert
Copy link
Collaborator Author

oeggert commented Mar 7, 2023

@intelliot I restored the reporting mode instructions and updated the links in that doc to point to BUILD.md; does this PR look ready to go otherwise?

@oeggert oeggert requested a review from intelliot March 7, 2023 00:03
@oeggert oeggert linked an issue Mar 7, 2023 that may be closed by this pull request
Update Ubuntu build instructions #1651
Closed
@oeggert oeggert mentioned this pull request Mar 7, 2023
Closed
8 tasks
@oeggert oeggert merged commit 292fed5 into 1100-release-docs Mar 8, 2023
@oeggert oeggert deleted the build-direction-redirects branch March 8, 2023 00:07
@oeggert oeggert mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 Awaiting requested review from mDuo13

@intelliot intelliot Awaiting requested review from intelliot

Assignees

@oeggert oeggert

Labels
content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts
Projects
XRPL Docs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Ubuntu build instructions
2 participants
@oeggert @intelliot