Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old "New in: rippled X.Y.Z" badges #1978

Closed
mDuo13 opened this issue Jun 27, 2023 · 1 comment
Closed

Remove old "New in: rippled X.Y.Z" badges #1978

mDuo13 opened this issue Jun 27, 2023 · 1 comment
Labels
organization Information architecture, restructuring, interlinking, etc.

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 27, 2023

The badges indicating when a feature was added are extraneous and sometimes distracting information when they refer to really old versions. You can't keep synced with the blockchain unless you're running a recent version anyway, so these are only useful for a limited time unless people are updating very outdated code or they're trying to do some sort of historical digging, in which case they should expect to rely on release notes anyway.

As a general policy, we should keep badges that are < ~2 years old (probably about 4-8 scheduled releases), which aligns with the timeline for retiring amendments (XLS-11d).

To avoid too many merge conflicts, this should be done on the IA.v3 branch or on the master branch after merging that one. (It's started in some places already.) We should also update the contributing guidelines to add the above rule/guidance.

@mDuo13 mDuo13 added the organization Information architecture, restructuring, interlinking, etc. label Jun 27, 2023
@intelliot
Copy link
Contributor

intelliot commented Jun 27, 2023

In certain cases (changes of historical importance), perhaps the badge could be replaced with a footnote, which is less distracting than a colored badge.

mDuo13 added a commit that referenced this issue Jan 23, 2024
Version 1.8.0 of rippled was released in late 2021, so any changes prior
to that are historical and no longer need badges.

Fixes #1978
mDuo13 added a commit that referenced this issue Jan 26, 2024
Version 1.8.0 of rippled was released in late 2021, so any changes prior
to that are historical and no longer need badges.

Fixes #1978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organization Information architecture, restructuring, interlinking, etc.
Projects
None yet
Development

No branches or pull requests

2 participants