Revert "Reduce duplicate peer traffic for ledger data (#5126)" #5300
+143
−1,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd5e655. It has introduced a regression causing slow close times and syncing issues. A fix will be attempted later.
ximinez
added
Bug
Trivial
vlntb
approved these changes
Feb 19, 2025
|
I can't approve my own request, but I rebased this branch, removing both dd5e655 and the new commit from this PR, and verified that the end result is identical. Has no output. |
ximinez
added
the
Ready to merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5300 +/- ##
=========================================
+ Coverage 77.9% 78.1% +0.2%
=========================================
Files 791 790 -1
Lines 68006 67683 -323
Branches 8346 8191 -155
=========================================
- Hits 52967 52873 -94
+ Misses 15039 14810 -229
... and 6 files with indirect coverage changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This reverts commit dd5e655. It has introduced a regression causing slow close times and syncing issues. A fix will be attempted later.
Context of Change
#5126 introduced duplicate message checking and suppression. The absence of those messages may explain the symptoms that are being seen on test networks.
Type of Change
API Impact
None
Before / After
Reverses the changes from #5126. The full set of changes does not necessarily have to be reviewed. It may be sufficient to verify that the code is what it would have been without that commit.
Future Tasks
Find and fix the actual bug. I have a feeling it's related to the message hashing.