docs: Clarifies default port of hosts #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthomee
added
Trivial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5290 +/- ##
=========================================
- Coverage 77.9% 77.9% -0.0%
=========================================
Files 791 791
Lines 68006 68006
Branches 8348 8350 +2
=========================================
- Hits 52961 52959 -2
- Misses 15045 15047 +2 see 1 file with indirect coverage changes |
|
When I saw this port being used I didn't realize it wasn't arbitrary and wondered why it wasn't the default in the config. |
|
This is more of a |
Fair - I was doubting between the two. |
bthomee
changed the title
kennyzlei
approved these changes
Feb 14, 2025
legleux
approved these changes
Feb 14, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The current comment in the example cfg file incorrectly mentions both "may" and "must". This change fixes this comment to clarify that the default port of hosts is 2459 and that specifying it is therefore optional. It further sets the default port to 2459 instead of the legacy 51235.
Type of Change