Remove lambda from rotateWithLock

[Bronek]

Possible improvement to PR #5276

This is based on assumption that we do not need to call clearCaches(validatedSeq) twice. There should be no reason to call it second time inside the critical section, just like there should be no reason to update state_db_ inside the critical section, so this change minimises the critical section and also removes the risk that some untested code from outside of DatabaseRotatingImp could run inside it.

[Bronek]

I would add levelization fix to this PR but the branch protection rules forbid me from adding any commits :-|

[codecov]

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (ximinez/db-lock@217bc1d). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/xrpld/nodestore/detail/DatabaseRotatingImp.cpp	54.5%	5 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##             ximinez/db-lock   #5286   +/-   ##
=================================================
  Coverage                   ?   78.2%           
=================================================
  Files                      ?     790           
  Lines                      ?   67634           
  Branches                   ?    8162           
=================================================
  Hits                       ?   52858           
  Misses                     ?   14776           
  Partials                   ?       0           

Files with missing lines	Coverage Δ
src/xrpld/app/misc/SHAMapStoreImp.cpp	76.8% <100.0%> (ø)
src/xrpld/nodestore/DatabaseRotating.h	100.0% <ø> (ø)
src/xrpld/nodestore/detail/DatabaseRotatingImp.h	66.7% <ø> (ø)
src/xrpld/nodestore/detail/DatabaseRotatingImp.cpp	61.2% <54.5%> (ø)

[Bronek]

Judging by comments in #3342 it seems that we do need both clearCaches and update state_db_ inside the critical section. :-(