Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go package names to GRPC protobuf definitions #5281

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

donovanhide
Copy link
Contributor

High Level Overview of Change

Add Go package names to GRPC protobuf definitions, as per:

https://protobuf.dev/reference/go/faq/#fix-namespace-conflict

Context of Change

Make the GRPC API available to Go developers without having to manually alter protobuf definition files.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • [ x] Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

bthomee
bthomee previously approved these changes Feb 12, 2025
@bthomee bthomee requested a review from ximinez February 12, 2025 22:44
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.2%. Comparing base (fa5a854) to head (cb67de8).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5281   +/-   ##
=======================================
  Coverage     78.2%   78.2%           
=======================================
  Files          790     790           
  Lines        67638   67638           
  Branches      8164    8161    -3     
=======================================
+ Hits         52860   52869    +9     
+ Misses       14778   14769    -9     

see 2 files with indirect coverage changes

Impacted file tree graph

@bthomee
Copy link
Collaborator

bthomee commented Feb 12, 2025

@donovanhide would you be able to sign your commit?

@donovanhide
Copy link
Contributor Author

Signed!

@bthomee bthomee dismissed their stale review February 13, 2025 14:02

Upon reflection, I need some more time to analyze this change. Current issues that come to mind:

  • There is no go.mod in this repo that defines the Go package.
  • The protos are not compiled into pb.go and included in this repo.
  • The go_package points to a different URL than where this repo is hosted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants