-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GRPCServer.cpp #5280
Update GRPCServer.cpp #5280
Conversation
Omit superfluous setCurrentThreadName call.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5280 +/- ##
=========================================
- Coverage 78.1% 78.1% -0.0%
=========================================
Files 790 790
Lines 67623 67622 -1
Branches 8163 8163
=========================================
- Hits 52846 52844 -2
- Misses 14777 14778 +1
|
@donovanhide To consistently follow the contributing process, can you please apply the "Ready to merge" label when this PR can be merged? |
Hi @bthomee Not sure I have permissions to add a label to this PR, unless I am missing some github magic? |
Ah true. In that case just commenting it's ok to have this PR merged is sufficient. Apologies for making you jump through a hoop. |
This PR is ready to merge! |
Omit superfluous setCurrentThreadName call.
High Level Overview of Change
Previous revert added back in two thread names.
ce570c1#diff-a5992bc868207dd320a19952bb4f5ffa326fd2581dd016fcb86afbeca07b7e93R695-R697
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)