Unit tests to recreate invalid index logic error #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
added
Bug
Tech Debt
ximinez
added a commit
that referenced
this pull request
Jan 10, 2025
* One hits the global cache, one does not. * Also some extra checking. Co-authored-by: Bronek Kozicki <brok@incorrekt.com>
ximinez
force-pushed
the
ximinez/objectid_tests
branch
from
dda3887 to
95b80a7
Compare
* One hits the global cache, one does not. * Also some extra checking. Co-authored-by: Bronek Kozicki <brok@incorrekt.com>
ximinez
force-pushed
the
ximinez/objectid_tests
branch
from
95b80a7 to
aef823e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5242 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66951 66953 +2
Branches 8111 8106 -5
=======================================
+ Hits 52211 52226 +15
+ Misses 14740 14727 -13
... and 6 files with indirect coverage changes |
mvadari
reviewed
Jan 10, 2025
src/test/app/Regression_test.cpp
Outdated
Comment on lines
267
to
282
| auto index = [&](auto account) { | ||
| Json::Value req(Json::objectValue); | ||
| req[jss::account] = account; | ||
| auto const resp = env.rpc("json", "account_info", to_string(req)); | ||
| BEAST_EXPECT( | ||
| resp.isMember(jss::result) && resp[jss::result].isObject()); | ||
| auto const& result = resp[jss::result]; | ||
| BEAST_EXPECT( | ||
| result.isMember(jss::account_data) && | ||
| result[jss::account_data].isObject()); | ||
| auto const& ad = result[jss::account_data]; | ||
| BEAST_EXPECT(ad.isMember(jss::index) && ad[jss::index].isString()); | ||
| uint256 index; | ||
| BEAST_EXPECT(index.parseHex(ad[jss::index].asString())); | ||
| return index; | ||
| }; |
There was a problem hiding this comment.
I think this can be greatly simplified by using keylet::account(alice)
There was a problem hiding this comment.
excellent idea. That will make this whole lambda unnecessary. I added the necessary proposed changes.
There was a problem hiding this comment.
I think this can be greatly simplified by using
keylet::account(alice)
Thanks @mvadari. That was a great observation and suggestion.
Bronek
reviewed
Jan 13, 2025
Bronek
reviewed
Jan 13, 2025
src/test/app/Regression_test.cpp
Outdated
Comment on lines
267
to
282
| auto index = [&](auto account) { | ||
| Json::Value req(Json::objectValue); | ||
| req[jss::account] = account; | ||
| auto const resp = env.rpc("json", "account_info", to_string(req)); | ||
| BEAST_EXPECT( | ||
| resp.isMember(jss::result) && resp[jss::result].isObject()); | ||
| auto const& result = resp[jss::result]; | ||
| BEAST_EXPECT( | ||
| result.isMember(jss::account_data) && | ||
| result[jss::account_data].isObject()); | ||
| auto const& ad = result[jss::account_data]; | ||
| BEAST_EXPECT(ad.isMember(jss::index) && ad[jss::index].isString()); | ||
| uint256 index; | ||
| BEAST_EXPECT(index.parseHex(ad[jss::index].asString())); | ||
| return index; | ||
| }; |
There was a problem hiding this comment.
excellent idea. That will make this whole lambda unnecessary. I added the necessary proposed changes.
Co-authored-by: Bronek Kozicki <brok@incorrekt.com>
mvadari
approved these changes
Jan 16, 2025
ximinez
added
the
Ready to merge
|
Ready to merge once CI finishes. The commit message from the first commit will be sufficient for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add unit tests and extra checks to reproduce and check that the caching issue fixed in version 2.3.0 is resolved and does not recur.
Context of Change
https://dev.to/ripplexdev/november-25-xrpl-bug-current-status-and-whats-next-b61
The tests were not released with the fix because it makes it obvious how to exploit the issue, which would give bad actors too much information.
Type of Change
Test Plan
Only changes unit tests and an
assert, so as long as tests pass, all is well.Future Tasks