Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deprecated Github Actions #5241

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 9, 2025

High Level Overview of Change

This PR updates actions/upload-artifact and actions-download-artifact from v3 to v4 (the current version).

Context of Change

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Starting January 30th, 2025, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact.

Some actions are already starting to fail for this reason.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

API Impact

N/A

Test Plan

CI passes.

@mvadari mvadari force-pushed the deprecated-action branch from c264640 to dfcd539 Compare January 9, 2025 20:58
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (58af62f) to head (dfcd539).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5241   +/-   ##
=======================================
  Coverage     77.9%   77.9%           
=======================================
  Files          785     785           
  Lines        66757   66757           
  Branches      8119    8118    -1     
=======================================
  Hits         52005   52005           
  Misses       14752   14752           

see 2 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proof is in the pudding: All the CI jobs succeeded.

@ximinez ximinez merged commit 07f118c into XRPLF:develop Jan 9, 2025
21 checks passed
@ximinez ximinez added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 9, 2025
@mvadari mvadari deleted the deprecated-action branch January 9, 2025 21:33
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants