XLS-78d: Subscriptions

[dangell7]

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

Attention: Patch coverage is 80.43478% with 72 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (1fbf8da) to head (30b8538).

Files with missing lines	Patch %	Lines
src/xrpld/app/tx/detail/Subscription.cpp	78.3%	70 Missing ⚠️
src/xrpld/rpc/handlers/LedgerEntry.cpp	92.9%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #5136    +/-   ##
========================================
  Coverage     76.2%   76.2%            
========================================
  Files          760     762     +2     
  Lines        61568   61936   +368     
  Branches      8126    8162    +36     
========================================
+ Hits         46909   47203   +294     
- Misses       14659   14733    +74     

Files with missing lines	Coverage Δ
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h	100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
src/libxrpl/protocol/Feature.cpp	94.6% <ø> (ø)
src/libxrpl/protocol/Indexes.cpp	97.6% <100.0%> (+<0.1%)	⬆️
src/libxrpl/protocol/LedgerFormats.cpp	100.0% <100.0%> (ø)
src/libxrpl/protocol/SField.cpp	77.5% <ø> (ø)
src/libxrpl/protocol/TxFormats.cpp	100.0% <100.0%> (ø)
src/xrpld/app/tx/detail/InvariantCheck.cpp	91.1% <ø> (ø)
src/xrpld/app/tx/detail/Subscription.h	100.0% <100.0%> (ø)
... and 4 more

... and 4 files with indirect coverage changes