Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed version 2.2.2 #5115

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Proposed version 2.2.2 #5115

merged 4 commits into from
Sep 3, 2024

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Aug 31, 2024

High Level Overview of Change

This is a hotfix release that fixes a ongoing issue on Mainnet where a majority of UNL validators will stall during consensus processing due to lock contention, preventing ledgers from being validated for up to two minutes.

The base branch is master. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to master, and reverse-merged to develop. Do not use the Github UI to merge this PR


This PR / branch is identical to #5106, which is currently being tested, with two exceptions:

  • The version number is updated
  • The commits are reorganized and "cleaned up" for release.
$ git fetch origin && git diff origin/pr/2.2.2-rc1 origin/master-next 
diff --git a/src/ripple/protocol/impl/BuildInfo.cpp b/src/ripple/protocol/impl/BuildInfo.cpp
index 44aef03533..0086824b7e 100644
--- a/src/ripple/protocol/impl/BuildInfo.cpp
+++ b/src/ripple/protocol/impl/BuildInfo.cpp
@@ -33,7 +33,7 @@ namespace BuildInfo {
 //  and follow the format described at http://semver.org/
 //------------------------------------------------------------------------------
 // clang-format off
-char const* const versionString = "2.2.2-rc2"
+char const* const versionString = "2.2.2"
 // clang-format on
 
 #if defined(DEBUG) || defined(SANITIZER)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Release

vlntb and others added 4 commits August 26, 2024 19:03
* Log when duplicate concurrent inbound ledger are filtered.
* RAII for containers that track concurrent inbound ledger.
* Comment on when to asynchronously acquire inbound ledgers, which
   is possible to be always OK, but should have further review.
* Other small logging changes

Co-authored-by: Ed Hennis <ed@ripple.com>
* refactor filtering of validations to specifically avoid
 concurrent checkAccept() calls for the same validation ledger hash.
* Log when duplicate concurrent validation requests are filtered.
* RAII for containers that track concurrent validation requests.
@ximinez ximinez added Bug Syncing issue Trouble getting or keeping a server synced with the network labels Aug 31, 2024
@ximinez ximinez mentioned this pull request Aug 31, 2024
13 tasks
@Bronek Bronek self-requested a review September 2, 2024 17:08
@Bronek Bronek self-requested a review September 2, 2024 18:33
Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mDuo13
Copy link
Collaborator

mDuo13 commented Sep 3, 2024

This PR should edit RELEASENOTES.md to add the new release.

The changes can be relatively small. The opening sentence of this PR is good for the overview.

@ximinez ximinez merged commit 85214bd into XRPLF:master Sep 3, 2024
16 of 17 checks passed
@ximinez
Copy link
Collaborator Author

ximinez commented Sep 3, 2024

This PR should edit RELEASENOTES.md to add the new release.

The changes can be relatively small. The opening sentence of this PR is good for the overview.

I saw this after merging the PR. Do you think we'd be ok adding release notes when we reverse merge into develop?

@WietseWind
Copy link
Member

WietseWind commented Sep 5, 2024

FYI @ximinez @mtrippled - this seems to make a difference on FH nodes @ xrplcluster - less transitions, less hiccups in ledger steram over websocket.

Installed it on half the machines and the ones with 2.2.2 definitely seem to do significantly better.

@ximinez
Copy link
Collaborator Author

ximinez commented Sep 5, 2024

This is great news, @WietseWind ! Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Syncing issue Trouble getting or keeping a server synced with the network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants