Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #5094

Merged
merged 2 commits into from
Sep 16, 2024
Merged

chore: fix some comments #5094

merged 2 commits into from
Sep 16, 2024

Conversation

luozexuan
Copy link
Contributor

@luozexuan luozexuan commented Aug 9, 2024

High Level Overview of Change

fix some comments

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

luozexuan and others added 2 commits August 9, 2024 23:10
Signed-off-by: luozexuan <fetchcode@139.com>
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this only touches comments

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8%. Comparing base (d9bd75e) to head (dd6b60e).
Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5094     +/-   ##
=========================================
- Coverage     74.9%   74.8%   -0.0%     
=========================================
  Files          768     768             
  Lines        63134   63134             
  Branches      8846    8866     +20     
=========================================
- Hits         47269   47248     -21     
- Misses       15865   15886     +21     
Files with missing lines Coverage Δ
src/libxrpl/protocol/tokens.cpp 93.7% <ø> (ø)
src/xrpld/app/tx/detail/Transactor.cpp 84.7% <ø> (ø)

... and 7 files with indirect coverage changes

Impacted file tree graph

@intelliot
Copy link
Collaborator

merging because this is trivial

@intelliot intelliot merged commit 9a6af9c into XRPLF:develop Sep 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants