Enable publishing subsequent ledgers even if a prior one has not been acquired yet. #5068
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has not been acquired yet.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5068 +/- ##
=======================================
Coverage 71.3% 71.4%
=======================================
Files 796 796
Lines 67031 67036 +5
Branches 10885 10869 -16
=======================================
+ Hits 47808 47833 +25
+ Misses 19223 19203 -20
... and 6 files with indirect coverage changes |
Bronek
reviewed
Jul 29, 2024
Bronek
changed the title
Bronek
approved these changes
Aug 1, 2024
intelliot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removes logjam of ledgers to update bookkeeping for if one of them has not been acquired.
Context of Change
The bug was first noticed in testing of 2.x builds in an internal to Ripple test environment.
Type of Change
API Impact
This change has run internally for over a week by now, with no reproduction of the original
problem, and no new problems introduced. Prior to this, the problem was happening as
frequently as each day.
Investigate problems acquiring recent ledgers that have yet to be published which triggered
the logjam fixed by this PR. There's possibly peer resource contention in that environment, but TBD.