-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change error for invalid feature
param in feature
RPC
#5063
Conversation
11d072c
to
846dcf3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5063 +/- ##
=========================================
- Coverage 71.4% 71.4% -0.0%
=========================================
Files 796 796
Lines 67039 67042 +3
Branches 10864 10864
=========================================
+ Hits 47844 47846 +2
- Misses 19195 19196 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK because this is a relatively new RPC, and it is not involved in how integrations do tx processing (where any potential API breakage would be more painful)
This is ready to merge. |
High Level Overview of Change
This PR changes the error message for invalid values of
feature
in thefeature
RPC. Now, if a non-string is passed into the function, it will returninvalidParams
, instead ofbadFeature
as it did before.Context of Change
In rippled 2.2.0, a non-admin version of
feature
was added. This makes the need for proper error handling more important.Type of Change
API Impact
While this is technically a breaking change, I consider it more of a bugfix. Only the error message is changing.
Test Plan
Additional unit tests were added.