Fix Oracle's token pair deterministic order #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Price Oracle data-series logic uses `unordered_map` to update the Oracle object. This results in different servers disagreeing on the order of that hash table. Consequently, the generated ledgers will have different hashes. The fix uses `map` instead to guarantee the order of the token pairs in the data-series.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5021 +/- ##
=======================================
Coverage 71.1% 71.1%
=======================================
Files 796 796
Lines 66997 66997
Branches 10982 10979 -3
=======================================
Hits 47635 47635
Misses 19362 19362
... and 3 files with indirect coverage changes |
scottschurr
approved these changes
May 20, 2024
seelabs
approved these changes
May 20, 2024
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Price Oracle data-series logic uses `unordered_map` to update the Oracle object. This results in different servers disagreeing on the order of that hash table. Consequently, the generated ledgers will have different hashes. The fix uses `map` instead to guarantee the order of the token pairs in the data-series.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Price Oracle data-series logic uses
unordered_mapto update the Oracle object. This results in different servers disagreeing on the order of that hash table. Consequently, the generated ledgers will have different hashes. The fix usesmapinstead to guarantee the order of the token pairs in the data-series.Type of Change
.gitignore, formatting, dropping support for older tooling)