Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Add missing includes #5011

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

thejohnfreeman
Copy link
Collaborator

These direct includes are missing but will not be diagnosed until includes are rewritten in the physical redesign PR.

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.9%. Comparing base (5aa1106) to head (b197486).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5011     +/-   ##
=========================================
- Coverage     70.9%   70.9%   -0.0%     
=========================================
  Files          796     796             
  Lines        66792   66792             
  Branches     11002   11000      -2     
=========================================
- Hits         47379   47372      -7     
- Misses       19413   19420      +7     
Files Coverage Δ
src/ripple/conditions/impl/utils.h 69.4% <ø> (ø)
src/ripple/consensus/LedgerTrie.h 85.8% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

@seelabs seelabs merged commit 7612805 into XRPLF:develop May 2, 2024
17 checks passed
@thejohnfreeman thejohnfreeman deleted the includes branch May 2, 2024 15:16
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants