Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flow assert: #5009

Merged
merged 1 commit into from
May 1, 2024
Merged

Remove flow assert: #5009

merged 1 commit into from
May 1, 2024

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented May 1, 2024

Rounding in the payment engine is causing an assert to sometimes fire with "dust" amounts. This is causing issues when running debug builds of rippled. This issue will be addressed, but the assert is no longer serving its purpose.

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)

@seelabs seelabs requested review from Bronek and scottschurr May 1, 2024 15:44
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was hard to choose to do this, but I think this is a good choice. Having this assert fire was training me to be dismissive of asserts.

@Bronek
Copy link
Collaborator

Bronek commented May 1, 2024

I know it was hard to choose to do this, but I think this is a good choice. Having this assert fire was training me to be dismissive of asserts.

I think as long as we:

  • know the reason for the assert fail and
  • are confident the severity does not warrant it and
  • reject the transaction anyway

... it's fine not to have it

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 1, 2024
Rounding in the payment engine is causing an assert to sometimes fire
with "dust" amounts. This is causing issues when running debug builds of
rippled. This issue will be addressed, but the assert is no longer
serving its purpose.
@seelabs seelabs merged commit 5aa1106 into XRPLF:develop May 1, 2024
8 checks passed
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Rounding in the payment engine is causing an assert to sometimes fire
with "dust" amounts. This is causing issues when running debug builds of
rippled. This issue will be addressed, but the assert is no longer
serving its purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants