Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external directory for Conan recipe's exports #5006

Merged
merged 2 commits into from
May 2, 2024

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Apr 29, 2024

High Level Overview of Change

Adds a the external directory to the Conan exports required for generating the libxrpl Conan package.

Context of Change

Without exporting the contents of external/, package generation errors out with:

CMake Error at CMakeLists.txt:73 (add_subdirectory):
  add_subdirectory given source "external/secp256k1" which is not an existing
  directory.
CMake Error at CMakeLists.txt:74 (add_library):
  add_library cannot create ALIAS target "secp256k1::secp256k1" because
  target "secp256k1" does not already exist.
CMake Error at CMakeLists.txt:75 (add_subdirectory):
  add_subdirectory given source "external/ed25519-donna" which is not an
  existing directory.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.9%. Comparing base (7612805) to head (780f5c1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5006     +/-   ##
=========================================
- Coverage     70.9%   70.9%   -0.0%     
=========================================
  Files          796     796             
  Lines        66792   66792             
  Branches     10996   10997      +1     
=========================================
- Hits         47381   47379      -2     
- Misses       19411   19413      +2     

see 2 files with indirect coverage changes

Impacted file tree graph

@thejohnfreeman
Copy link
Collaborator

thejohnfreeman commented May 1, 2024

There will be yet more new exports (include/, cmake/) after the physical redesign is complete, but this reminds me that I need to add them to the final PR (#4997).

@legleux legleux added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 2, 2024
@seelabs seelabs merged commit f650949 into XRPLF:develop May 2, 2024
17 checks passed
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants