Proposed 2.1.1 #4968
Merged
Proposed 2.1.1 #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large synthetic offer was not handled correctly in the payment engine. This patch fixes that issue and introduces a new invariant check while processing synthetic offers.
seelabs
force-pushed
the
master-next
branch
2 times, most recently
from
01f4987
to
42e41cf
Compare
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4968 +/- ##
==========================================
- Coverage 61.53% 61.49% -0.04%
==========================================
Files 797 797
Lines 70158 70199 +41
Branches 36261 36287 +26
==========================================
+ Hits 43170 43171 +1
- Misses 19753 19779 +26
- Partials 7235 7249 +14 ☔ View full report in Codecov by Sentry. |
tequdev
approved these changes
Mar 27, 2024
desimmons
reviewed
Mar 27, 2024
RELEASENOTES.md
Outdated
|
|
||
| ### Amendments | ||
|
|
||
| - **fixAMMOverflowOffer**: Fix improper handling of a large synthetic AMM offers in the payment engine. Due to the importance of this fix, the default vote in the source code has been set to YES. For information on how to configure your validator's amendment voting, see [Configure Amendment Voting](https://xrpl.org/docs/infrastructure/configuration/configure-amendment-voting). |
There was a problem hiding this comment.
Nit:
- Remove "a": "... handling of a large synthetic AMM ..." -> "... handling of large synthetic AMM ..."
or
- Remove plural: "... AMM offers ... " -> "... AMM offer ... "
Bronek
approved these changes
Mar 27, 2024
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 28, 2024
Merging changes for 2.1.1 from master into develop
2 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a hotfix release that fixes a critical bug when handling of a large synthetic AMM offers in the payment engine.
Type of Change