-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elaborate Error Message for rpcInternal #4959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a consequence of lumping client and server into the same executable. :/
Needs to be reformatted. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4959 +/- ##
=========================================
- Coverage 76.2% 76.2% -0.0%
=========================================
Files 760 760
Lines 61568 61568
Branches 8126 8126
=========================================
- Hits 46909 46899 -10
- Misses 14659 14669 +10
|
Validator operators have been confused by the rpcInternal error, which can occur if the server is not running in another process.
High Level Overview of Change
Validator operators are often flummoxed by the below error:
It would be helpful if the error message can instruct the users to run the rippled server in another process (
./rippled
) before executing any of the command-line client commands.Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)This is an elaboration of an error message.
API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)No change to API. No impact on performance either.
I manually verified (on MacOS) that the new error message is displayed, if rippled server isn't running in the background.