Change order of checks in amm_info #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
feature/change_amm_info_error
branch
from
58ef31b
to
99ea4fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4924 +/- ##
=========================================
- Coverage 71.3% 71.3% -0.0%
=========================================
Files 796 796
Lines 66981 66987 +6
Branches 10871 10887 +16
=========================================
- Hits 47774 47763 -11
- Misses 19207 19224 +17
... and 8 files with indirect coverage changes |
intelliot
added
Clio Reviewed
APIv3
gregtatcam
reviewed
Feb 22, 2024
|
this is good to merge - note it preserves the current behaviour in API version 2 and adds a test for it. |
|
Is this going to be merged soon? |
|
@godexsoft Yes, it should be merged today. |
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jul 1, 2024
* upstream/develop: (32 commits) fixInnerObjTemplate2 amendment (XRPLF#5047) Set version to 2.3.0-b1 Ignore restructuring commits (XRPLF#4997) Recompute loops (XRPLF#4997) Rewrite includes (XRPLF#4997) Rearrange sources (XRPLF#4997) Move CMake directory (XRPLF#4997) Add bin/physical.sh (XRPLF#4997) Prepare to rearrange sources: (XRPLF#4997) Change order of checks in amm_info: (XRPLF#4924) Add the fixEnforceNFTokenTrustline amendment: (XRPLF#4946) Replaces the usage of boost::string_view with std::string_view (XRPLF#4509) docs: explain how to find a clang-format patch generated by CI (XRPLF#4521) XLS-52d: NFTokenMintOffer (XRPLF#4845) chore: remove repeat words (XRPLF#5041) Expose all amendments known by libxrpl (XRPLF#5026) fixReducedOffersV2: prevent offers from blocking order books: (XRPLF#5032) Additional unit tests for testing deletion of trust lines (XRPLF#4886) Fix conan typo: (XRPLF#5044) Add new command line option to make replaying transactions easier: (XRPLF#5027) ...
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
* Change order of checks in amm_info * Change amm_info error message in API version 3 * Change amm_info error tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Checking if account is well-formed currently happens before the check if
asset,asset2andamm_accountare supplied, which results in an unexpected error messages if any of the fields is malformed. Swap the order of checks, so validity of fields is verified first. Since this is a breaking change, retain the existing behaviourif (apiVersion < 3)and add identical check, but after checks of assets and accounts,if (apiVersion >= 3). Also add unit tests to demonstrate the old and new behaviour.Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Before: sending an invalid account or asset to
amm_infoRPC method while other parameters are not set as expected would result inrpcINVALID_PARAMSerror. This behaviour is retained in API version 2After: sending an invalid account or asset to
amm_infoRPC method while other parameters are not set as expected will result inrpcISSUE_MALFORMEDorrpcACT_MALFORMEDerror. This behaviour is new in API version 3This resolves XRPLF/clio#1157