Proposed 2.1.0 #4920
Merged
Proposed 2.1.0 #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Commit 01c37fe introduced a change to the STTx unit test where a local "defaultRules" object was created with a temporary inline "presets" value provided to the ctor. Rules::Impl stores a const ref to the presets provided to the ctor. This particular call provided an inline temp variable, which goes out of scope as soon as the object is created. On Windows, attempting to use the presets (e.g. via the enabled() function) causes an access violation, which crashes the test run. * An audit of the code indicates that all other instances of Rules use the Application's config.features list, which will have a sufficient lifetime.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #4920 +/- ##
===========================================
- Coverage 61.52% 61.50% -0.02%
===========================================
Files 797 797
Lines 70158 70157 -1
Branches 36261 36261
===========================================
- Hits 43163 43152 -11
- Misses 19753 19757 +4
- Partials 7242 7248 +6 ☔ View full report in Codecov by Sentry. |
intelliot
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Comparison with 2.0.1 (last stable release): 2.0.1...3895468
Target release date: Feb 20, 2024
kennyzlei
approved these changes
Feb 17, 2024
ximinez
requested changes
Feb 20, 2024
ximinez
force-pushed
the
develop-next
branch
from
3895468 to
d7d15a9
Compare
ximinez
approved these changes
Feb 21, 2024
|
So it turns out that I can't push to Edit: Got it pushed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This release introduces two amendments:
Additionally, there are test improvements, improvements to
libxrpl, and relaxed validation forport_grpcinrippled.cfg.The base branch is
release. All releases (including betas) go inrelease. This PR will be merged with--ff-only(not squashed or rebased, and not using the GitHub UI).Type of Change
API Impact
Improvements to
libxrplhelp dependents likevalidator-keys-toolandxbridge_witness.If/when amendments activate, changes to transaction processing - as implemented by those amendments - will take effect.