Update Appveyor dependencies package: #2286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miguelportilla
commented
Nov 30, 2017
•
miguelportilla
commented
- boost 1.64, including b2.exe and bjam.exe, and OpenSSL 1.0.2j.
- Use the Visual Studio 2017 image.
- Add boost serialization library.
miguelportilla
requested review from
ximinez
and removed request for
ximinez
miguelportilla
force-pushed
the
appveyor
branch
2 times, most recently
from
6bded7b to
59af6da
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2286 +/- ##
========================================
Coverage 70.22% 70.22%
========================================
Files 692 692
Lines 50961 50961
========================================
Hits 35787 35787
Misses 15174 15174
Continue to review full report at Codecov.
|
* Use the Visual Studio 2017 image * Update to rippled_deps17.01
miguelportilla
force-pushed
the
appveyor
branch
from
59af6da to
0ce55d9
Compare
bachase
approved these changes
Dec 1, 2017
There was a problem hiding this comment.
Minor nit, the versions.txt in the zip file says
Boost 1.62
Built using:
bjam --toolset=msvc-14.0 address-model=64 architecture=x86 link=static threading=multi runtime-link=shared,static stage --stagedir=stage64
But I think it has boost 1.64 inside. Is that also the same command line for building boost you used?
|
Thanks, I updated the file. That command line was used except 14.1 vs 14.0. |
|
Updated zip looks good 👍 |
mellery451
approved these changes
Dec 1, 2017
Merged
|
In 0.90.0-b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.