Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book_changes is missing "validated": true field in JSON-RPC response #5035

Closed
mDuo13 opened this issue May 31, 2024 · 0 comments
Closed

book_changes is missing "validated": true field in JSON-RPC response #5035

mDuo13 opened this issue May 31, 2024 · 0 comments

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented May 31, 2024

Issue Description

API methods that may return data from validated or unvalidated ledger versions are supposed to specify "validated": true when they pull data from a validated ledger version. The book_changes API method does this in the WebSocket version but not the JSON-RPC version for some reason.

Steps to Reproduce

Send a JSON-RPC request such as the following to a mainnet server:

{
    "method": "book_changes",
    "params": [{
      "ledger_index": 88377311
    }]
}

Expected Result

The response should have "validated": true in the result field.

Actual Result

There is no such field.

Environment

Tested on xrplcluster.com servers.

Clio servers (such as the ones in s1.ripple.com) do not seem to have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant