Skip to content

Commit

Permalink
Review fixes 3
Browse files Browse the repository at this point in the history
  • Loading branch information
oleks-rip committed Feb 5, 2025
1 parent eee4dab commit 6b325d9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion include/xrpl/protocol/Feature.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ namespace detail {
// Feature.cpp. Because it's only used to reserve storage, and determine how
// large to make the FeatureBitset, it MAY be larger. It MUST NOT be less than
// the actual number of amendments. A LogicError on startup will verify this.
static constexpr std::size_t numFeatures = 87;
static constexpr std::size_t numFeatures = 88;

/** Amendments that this server supports and the default voting behavior.
Whether they are enabled depends on the Rules defined in the validated
Expand Down
10 changes: 5 additions & 5 deletions src/test/app/Credentials_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,11 @@ struct Credentials_test : public beast::unit_test::suite
{
using namespace test::jtx;

bool const enabled = features[fixTransactionFlags];
testcase(
std::string("Test flag, fix ") +
(enabled ? "enabled" : "disabled"));

const char credType[] = "abcde";
Account const issuer{"issuer"};
Account const subject{"subject"};
Expand All @@ -1075,11 +1080,6 @@ struct Credentials_test : public beast::unit_test::suite
env.close();

{
bool const enabled = features[fixTransactionFlags];
testcase(
std::string("Test flag, fix ") +
(enabled ? "enabled" : "disabled"));

ter const expected(
enabled ? TER(temINVALID_FLAG) : TER(tesSUCCESS));
env(credentials::create(subject, issuer, credType),
Expand Down

0 comments on commit 6b325d9

Please sign in to comment.