feat: LPT freeze #1840
Open
feat: LPT freeze #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@godexsoft @cindyyan317 This PR is ready for review. There is still a test CI issue around |
shawnxie999
commented
Jan 27, 2025
There was a problem hiding this comment.
@cindyyan317 Would you mind giving this (and SubscriptionManagerTests.cpp) a quick review when you get a chance? If you spot anything obvious that could be causing the segfault in SubscriptionManagerAsyncTest, that’d be super helpful! I thought my changes were pretty minimal but it may have broke it somewhere that I could not reproduce on my mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRPLF/rippled#5227
Introduces amendment gating in
accountHoldsthat so that the assets in the AMM are not frozen