Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add more account check #1543

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

cindyyan317
Copy link
Collaborator

Make sure all char is alphanumeric for account

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Need to fix the formatting on the doxygen and we are good to go 🚀

src/util/AccountUtils.hpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.52%. Comparing base (46a616c) to head (ae7e1a9).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/rpc/handlers/GatewayBalances.hpp 0.00% 0 Missing and 2 partials ⚠️
src/rpc/handlers/LedgerEntry.hpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
+ Coverage    68.48%   68.52%   +0.03%     
===========================================
  Files          238      239       +1     
  Lines         9641     9654      +13     
  Branches      5349     5356       +7     
===========================================
+ Hits          6603     6615      +12     
+ Misses        1649     1648       -1     
- Partials      1389     1391       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cindyyan317 cindyyan317 merged commit d6598f3 into XRPLF:develop Jul 15, 2024
17 checks passed
godexsoft pushed a commit that referenced this pull request Jul 18, 2024
Make sure all char is alphanumeric for account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants