Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding and Codec creation directly from qc-exponents #19

Merged
merged 23 commits into from
May 2, 2024

Conversation

adomasbaliuka
Copy link
Contributor

No description provided.

Also lets tests inherit c++ standard from library
Now, colptr and row_idx are not stored at all. Instead, the pos_varn of the mother matrix is computed and stored.
This allows using a (colptr, row_idx) pair to build a RateAdaptiveCode but also alows using an abstract Encoder without having to store the encoder.
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 59.81308% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 47.90%. Comparing base (30f63df) to head (06b144f).

Files Patch % Lines
src/rate_adaptive_code.hpp 65.15% 4 Missing and 19 partials ⚠️
tests/test_rate_adaptive_code.cpp 50.00% 0 Missing and 23 partials ⚠️
src/encoder_advanced.hpp 68.18% 13 Missing and 8 partials ⚠️
tests/test_encoder_advanced.cpp 52.00% 0 Missing and 12 partials ⚠️
benchmarks_error_rate/code_simulation_helpers.hpp 28.57% 3 Missing and 2 partials ⚠️
src/encoder.hpp 50.00% 0 Missing and 1 partial ⚠️
tests/test_read_ldpc_from_files.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   46.47%   47.90%   +1.42%     
==========================================
  Files          11       13       +2     
  Lines         936     1073     +137     
  Branches      559      613      +54     
==========================================
+ Hits          435      514      +79     
- Misses         82       98      +16     
- Partials      419      461      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adomasbaliuka
Copy link
Contributor Author

Breaking changes:

  • removes RateAdaptiveCode template parameter Bit. This is now a template parameter of underlying functions, which is more flexible (and hopefully not too much more complicated/prone to errors...)
  • (ABI-breaking) reworks underlying data representation for RateAdaptiveCode.

Non-breaking changes:

  • New header encoder_advanced.hpp. Enables constexpr storage of QC-exponents for a code in a grouped manner. For how to use, see unit test in test_encoder_advanced.cpp. Requires C++20.
  • Enable construction of RateAdaptiveCode from a vector<vector<idx_t>> mother_pos_varn
  • Together, these also enable creating RateAdaptiveCode from QC-exponents stored statically in C++.

@adomasbaliuka adomasbaliuka merged commit 8677201 into main May 2, 2024
4 checks passed
@adomasbaliuka adomasbaliuka deleted the play_with_constexpr_objects branch May 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant