Use asn1crypto instead of pyasn1 to match cryptography lib #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 95.32% 95.26% -0.07%
==========================================
Files 3 3
Lines 599 591 -8
==========================================
- Hits 571 563 -8
Misses 28 28
Continue to review full report at Codecov.
|
|
Great, thanks! |
kislyuk
reviewed
Apr 24, 2017
|
|
||
| Changes for v2.3.0 (2017-??-??) | ||
| =============================== | ||
| - Replace pyasn1 with asn1crypto to match cryptography library |
There was a problem hiding this comment.
FYI, the changelog gets created automatically by https://github.com/XML-Security/signxml/blob/master/common.mk#L28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces pyasn1 with asn1crypto, just as the cryptography library has done. It uses a similar substitution as https://github.com/pyca/cryptography/pull/3361/files#diff-943ffbce399c77d88f98cb3cd9cdc82dR49 does for replacing encode, and goes one step further using from_p1363() in https://github.com/wbond/asn1crypto/blob/master/asn1crypto/algos.py#L531 which already does all the byte splitting that was performed in the code.