get serialNumber from subject #118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 94.89% 94.78% -0.11%
==========================================
Files 3 3
Lines 588 595 +7
==========================================
+ Hits 558 564 +6
- Misses 30 31 +1
Continue to review full report at Codecov.
|
|
Thank you for your contribution. Sorry about the delay in handling this PR. To proceed, this will require tests and the tightening of the comparisons in (Tests are failing for an unrelated reason - I'll fix that in master.) |
| def _get_serial_number(self, comps, serial): | ||
| for v in comps: | ||
| if len(v) == 2 and \ | ||
| v[0].decode('utf-8') in 'serialNumber' and \ |
There was a problem hiding this comment.
This comparison seems wrong. Why are you testing for a substring of 'serialNumber'?
There was a problem hiding this comment.
😄 definitely some autocomplete/paste issue.
I ended up omitting the serial number validation in my project and left the merge request half done, but since you want to give this attention I'll get back to this.
Thanks for a great library!
kislyuk
force-pushed
the
master
branch
5 times, most recently
from
04b5d0e to
c6b7dec
Compare
|
@busla any news about this ? travis is broken |
kislyuk
force-pushed
the
master
branch
2 times, most recently
from
8f30f82 to
06e5f93
Compare
kislyuk
force-pushed
the
develop
branch
4 times, most recently
from
7a5c538 to
6baf513
Compare
kislyuk
force-pushed
the
develop
branch
2 times, most recently
from
5ee9cd5 to
b87494d
Compare
kislyuk
force-pushed
the
develop
branch
4 times, most recently
from
6b21a86 to
6879c98
Compare
kislyuk
force-pushed
the
develop
branch
2 times, most recently
from
9717621 to
82ae152
Compare
kislyuk
force-pushed
the
develop
branch
4 times, most recently
from
7e7f504 to
b3de531
Compare
Allows the serialNumber to be extracted and validated from cert Subject.