Changes to the RunDB frontend for rucio #164
Conversation
straxen/rundb.py
Outdated
| @@ -105,8 +105,9 @@ def __init__(self, | |||
| self.collection = self.client[mongo_dbname][mongo_collname] | |||
|
|
|||
| self.backends = [ | |||
| strax.S3Backend(**s3_kwargs), | |||
| strax.FileSytemBackend(), | |||
| #strax.S3Backend(**s3_kwargs), | |||
There was a problem hiding this comment.
Why not removing those lines?
There was a problem hiding this comment.
These lines correspond to backends that still exist, so you have the choice between removing the comments, which will make you have 3 backends in all, or leaving it like that, which will make it go faster.
There was a problem hiding this comment.
Okay I do not get it why do we have to comment out those existing backends? Either they exist and we use them then we should not comment them out, or they do not exist and we do not use them, in this case we can remove those lines.
There was a problem hiding this comment.
You are right, I will remove the comments
|
Hej Sid, thanks a lot. I just briefly skimmed over the code. Could you a share with us some examples? |
Very good suggestion, you should already know that this is my first pr :). However I also have to submit a draft on strax (as you suggested to me), so the changes will be complete. |
Remove comments on S3Backend and FileSytemBackend backends
|
Hello everyone, given the particular structure of rucio, which for each file matches a sub-sub-folder, it was mandatory to create a new backend to manage this new structure, In the new structure, we use strax.rucio as the backend and the database frontend, you will find a notebook below which shows the tests I performed. Notebook: /dali/lgrandi/sahmedma/rucio-backend-test.ipynb |
|
Hi Sid, thanks a lot. Could you also upload this notebook to our analysis repo? This makes it easier for people to look into it. You could use the following directory: https://github.com/XENONnT/analysiscode/tree/master/StraxTests |
It's done. Thank you by teaching me how it works :) |
Removing try and except, which make some errors
|
This feature is tested and ready for merge. It is now available as AxFoundation/strax#300 is also merged |
straxen/rundb.py
Outdated
| @@ -40,6 +40,7 @@ def __init__(self, | |||
| local_only=False, | |||
| new_data_path=None, | |||
| reader_ini_name_is_mode=False, | |||
| rucio_path = '/dali/lgrandi/rucio/', | |||
There was a problem hiding this comment.
Not sure if we have anywhere in straxen dali related paths except for the contexts. Maybe you could change this into None and add this information simply to the context?
Hello, this is the long-awaited version that allows access to Rucio's data on Dali directly (I hope it works perfectly 🤞). Knowing that obviously I have already done a lot of tests.